Correct a coercion bug in capture manager #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
GeorgeHahn
approved these changes
Dec 10, 2024
blt
force-pushed
the
blt/correct_a_coercion_bug_in_capture_manager
branch
2 times, most recently
from
9e64967 to
324a605
Compare
blt
changed the base branch from
blt/avoid_potential_overflows
to
graphite-base/1139
blt
force-pushed
the
graphite-base/1139
branch
from
a01e841 to
b2d5858
Compare
blt
force-pushed
the
blt/correct_a_coercion_bug_in_capture_manager
branch
from
324a605 to
91744a0
Compare
blt
force-pushed
the
blt/correct_a_coercion_bug_in_capture_manager
branch
from
91744a0 to
4048edf
Compare
This commit corrects a bug whereby the capture manager did not coerce the u64 values up from the registry storage into their f64 representation, meaning we reported out to captures comically huge values. Much obliged to @tobz who spotted the bug. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/correct_a_coercion_bug_in_capture_manager
branch
from
4048edf to
ef5f4e1
Compare
This was referenced Dec 11, 2024
Merge activity
|
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit corrects a bug whereby the capture manager did not coerce the
u64 values up from the registry storage into their f64 representation, meaning
we reported out to captures comically huge values.
Much obliged to @tobz who spotted the bug.